Skip to content

Bump iohk-monitoring - drop dependency on snap #6020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgmeier wants to merge 1 commit into from
Closed

Bump iohk-monitoring - drop dependency on snap #6020

mgmeier wants to merge 1 commit into from

Conversation

@mgmeier
Copy link
Contributor

@mgmeier mgmeier commented Oct 22, 2024 •
edited
Loading

Description

This PR:

  1. bumps iohk-monitoring to a version that replaces the snap server beckend with wai / warp.
  2. switches all remaining build targets in the repo from snap-based ekg to ekg-wai.
  3. sensibly constrains ekg-forward (0.5 contains a space leak, and 0.7 will contain breaking changes).

This ultimately removes snap-server from node dependency graph entirely.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@mgmeier mgmeier changed the title Bump iohk-monitoring - ultimately removing snap-server from node dependency graph Bump iohk-monitoring - drop depency on snap Oct 22, 2024
@mgmeier mgmeier changed the title Bump iohk-monitoring - drop depency on snap Bump iohk-monitoring - drop dependency on snap Oct 22, 2024
@mgmeier mgmeier marked this pull request as ready for review October 22, 2024 11:05
@mgmeier mgmeier requested review from a team as code owners October 22, 2024 11:05
@mgmeier mgmeier requested a review from erikd October 22, 2024 11:05
erikd
erikd approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgmeier
Copy link
Contributor Author

mgmeier commented Nov 5, 2024

!! DO NOT MERGE !!

Dropping the snap dependency will be realized as part of the upcoming node release process (cc @neilmayhew )

@github-actions
Copy link

github-actions bot commented Dec 21, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Dec 21, 2024
@neilmayhew
Copy link
Contributor

neilmayhew commented Jan 10, 2025

Do I need to do anything with this?

@github-actions github-actions bot removed the Stale label Jan 11, 2025
@neilmayhew
Copy link
Contributor

neilmayhew commented Jan 27, 2025

This was cherry-picked in #6050

@neilmayhew neilmayhew closed this Jan 27, 2025
@neilmayhew neilmayhew deleted the mkarg/ekg-wai branch January 27, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikd erikd erikd approved these changes

Assignees

No one assigned

Labels

DO NOT MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgmeier @neilmayhew @erikd